Allow the public path to be set for Webpack chunk loading #182
+28
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prerequisite for fixing this farmOS core issue where farmOS-map chunks are not loaded for maps rendered via AJAX: https://www.drupal.org/project/farm/issues/3243922
The trick is that we need to set
__webpack_public_path__
in the farmOS-map entrypointmain.js
: https://stackoverflow.com/a/51245153. I chose to add this in a separatepublicPath.js
file as recommended by the Webpack On the fly docs (see warning message). This change works when simply added to the top ofmain.js
but it raises eslint errors so a separate import makes this cleaner as well.Added a quick note about this to the "Advanced integrations" section of the README, I'm not sure if we need to include additional details there?